Fix GDPopt LBB time-limit results by bernalde · Pull Request #3942 · Pyomo/pyomo

bernalde · 2026-05-11T13:38:13Z

Summary

Replace GDPopt LBB's stale _get_final_results_object() call on the time-limit path with _get_final_pyomo_results_object().
Add a solver-independent LBB regression test that forces the time-limit branch and verifies maxTimeLimit results.
Add MindtPy GOA time-limit coverage to verify its inherited GOA path sets maxTimeLimit on SolverResults.

Tests run

pytest -q pyomo/contrib/gdpopt/tests/test_LBB.py::TestGDPopt_LBB_TimeLimit::test_time_limit_returns_pyomo_results_object pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py::TestMindtPyGOATimeLimit::test_goa_time_limit_sets_solver_results_condition - passed, 2 passed in 0.52s
pytest -q pyomo/contrib/gdpopt/tests/test_LBB.py pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py - passed, 32 passed, 9 skipped, 2 deselected in 1.86s
python -m black --check --diff pyomo/contrib/gdpopt/branch_and_bound.py pyomo/contrib/gdpopt/tests/test_LBB.py pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py - passed, 3 files would be left unchanged
git diff --check -- pyomo/contrib/gdpopt/branch_and_bound.py pyomo/contrib/gdpopt/tests/test_LBB.py pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py - passed

Notes about tests not run

Full repository pytest and full-repository Black were not run locally because the targeted change is narrow and the full CI matrix covers multiple Python versions, platforms, optional solver installs, documentation, and coverage jobs.

Closes #3941

bernalde

Review summary

Blocking issues: none.
Nonblocking issues: none.
Questions: none.
Tests run:
- pytest -q pyomo/contrib/gdpopt/tests/test_LBB.py::TestGDPopt_LBB_TimeLimit::test_time_limit_returns_pyomo_results_object pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py::TestMindtPyGOATimeLimit::test_goa_time_limit_sets_solver_results_condition - passed, 2 passed in 0.50s.
- pytest -q pyomo/contrib/gdpopt/tests/test_LBB.py pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py - passed, 32 passed, 9 skipped, 2 deselected in 1.69s.
- python -m black --check --diff pyomo/contrib/gdpopt/branch_and_bound.py pyomo/contrib/gdpopt/tests/test_LBB.py pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py - passed, 3 files unchanged. Black emitted its Python 3.13 / Python 3.14 parser warning but completed successfully.
- git diff --check upstream/main...HEAD -- pyomo/contrib/gdpopt/branch_and_bound.py pyomo/contrib/gdpopt/tests/test_LBB.py pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py - passed.
- gh pr checks 3942 --repo Pyomo/pyomo - currently pending overall. Passing at review time: Read the Docs, lint/style-and-typos, linux/3.10/bare-env, linux/3.10/slim, linux/3.11/mpi, linux/3.12/numpy2. Remaining GitHub Actions matrix jobs and Jenkins inspection are still pending.
Merge as-is: I do not see code changes needed from review, but I would wait for the pending required CI/Jenkins statuses before merging.

bernalde · 2026-05-11T22:07:44Z

Coordination note for #3946:

This PR and #3946 fix different bugs. This one fixes the LBB time-limit result path for #3941; #3946 fixes continuous-node solver dispatch for #3945. #3946 does not supersede this PR.

I checked the combined patches with git merge-tree. The runtime changes are independent, but both PRs add imports/tests near the top of pyomo/contrib/gdpopt/tests/test_LBB.py, so the second PR merged will likely need a small conflict resolution there.

Recommendation: merge this PR first since it is smaller and already through the GitHub Actions matrix, then refresh/rebase #3946 afterward.

emma58

In the long run we should think about moving the GDPopt solvers onto the new contrib.solver results object, but this looks good for now--it fixes a dumb bug in LBB leftover from a long ago GDPopt rewrite.

emma58 · 2026-05-12T03:50:24Z


+class TestMindtPyGOATimeLimit(unittest.TestCase):
+    def test_goa_time_limit_sets_solver_results_condition(self):
+        from pyomo.contrib.mindtpy.global_outer_approximation import MindtPy_GOA_Solver


Can you move the import to the top of the file?

Addressed in ede4b3787 by moving MindtPy_GOA_Solver to the file-level imports in pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py. The GOA regression still passes with pytest -q pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py::TestMindtPyGOATimeLimit::test_goa_time_limit_sets_solver_results_condition.

bernalde · 2026-05-12T04:16:39Z

Review comments addressed.

Commits pushed:

ede4b3787 - Address MindtPy GOA test import review

Main changes made:

Moved MindtPy_GOA_Solver import from inside test_goa_time_limit_sets_solver_results_condition() to the top-level import block in pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py.

Tests run:

pytest -q pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py::TestMindtPyGOATimeLimit::test_goa_time_limit_sets_solver_results_condition - passed, 1 passed in 0.79s.
pytest -q pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py - passed, 29 passed in 1.59s.
pytest -q pyomo/contrib/gdpopt/tests/test_LBB.py::TestGDPopt_LBB_TimeLimit::test_time_limit_returns_pyomo_results_object pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py::TestMindtPyGOATimeLimit::test_goa_time_limit_sets_solver_results_condition - passed, 2 passed in 0.57s.
python -m black --check --diff pyomo/contrib/mindtpy/tests/test_mindtpy_no_discrete.py - passed, 1 file unchanged. Black emitted its Python 3.13 / Python 3.14 parser warning but completed successfully.

Comments intentionally not addressed:

The contrib.solver migration note was not addressed in this PR. The review described it as a long-run direction and approved the current bugfix. Migrating GDPopt and/or MindtPy result handling to contrib.solver is broader than the LBB stale-helper fix in GDPopt LBB time-limit path calls stale _get_final_results_object #3941. Related MindtPy tracking exists in MindtPy follow-up: evaluate contrib.solver migration for direct continuous solves #3936; no GDPopt-specific open issue turned up in a quick search.

Remaining risks or follow-up items:

Consider broadening MindtPy follow-up: evaluate contrib.solver migration for direct continuous solves #3936 or opening a sibling GDPopt issue for the longer-term contrib.solver migration work.

Fix GDPopt LBB time-limit results (Pyomo#3941)

c9ed4a6

bernalde commented May 11, 2026

View reviewed changes

bernalde mentioned this pull request May 11, 2026

Add LBB relaxed NLP node solver #3946

Open

emma58 added the AT: PRE-TEST INSPECTED label May 12, 2026

emma58 approved these changes May 12, 2026

View reviewed changes

pyomo-autotest removed the AT: PRE-TEST INSPECTED label May 12, 2026

Address MindtPy GOA test import review

ede4b37

bernalde mentioned this pull request May 12, 2026

MindtPy follow-up: evaluate contrib.solver migration for direct continuous solves #3936

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix GDPopt LBB time-limit results#3942

Fix GDPopt LBB time-limit results#3942
bernalde wants to merge 2 commits into
Pyomo:mainfrom
SECQUOIA:fix/issue-3941-gdpopt-lbb-time-limit

bernalde commented May 11, 2026

Uh oh!

bernalde left a comment

Uh oh!

bernalde commented May 11, 2026

Uh oh!

emma58 left a comment

Uh oh!

emma58 May 12, 2026

Uh oh!

bernalde May 12, 2026

Uh oh!

bernalde commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bernalde commented May 11, 2026

Uh oh!

bernalde left a comment

Choose a reason for hiding this comment

Uh oh!

bernalde commented May 11, 2026

Uh oh!

emma58 left a comment

Choose a reason for hiding this comment

Uh oh!

emma58 May 12, 2026

Choose a reason for hiding this comment

Uh oh!

bernalde May 12, 2026

Choose a reason for hiding this comment

Uh oh!

bernalde commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants